Fix font awesome icon classes #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arku
force-pushed
the
font-awesome-icon-fix
branch
from
9275eac to
b7e7ba4
Compare
Codecov Report
@@ Coverage Diff @@
## master #1354 +/- ##
=======================================
Coverage 30.63% 30.63%
=======================================
Files 124 124
Lines 8784 8784
Branches 1141 1141
=======================================
Hits 2691 2691
Misses 5985 5985
Partials 108 108Continue to review full report at Codecov.
|
arku
force-pushed
the
font-awesome-icon-fix
branch
from
b7e7ba4 to
f00c083
Compare
thelostone-mc
added
bug
thelostone-mc
approved these changes
Jun 4, 2018
|
⚡️ A tip worth 0.025 ETH (15.38 USD @ $615.06/ETH) has been granted to @arun1595 for this issue from thelostone-mc. ⚡️ The sender had the following public comments:
Nice work @arun1595! To redeem your tip, login to Gitcoin at https://gitcoin.co/explorer and select 'Claim Tip' from dropdown menu in the top right, or check your email for a link to the tip redemption page.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes weird rendering of font awesome icons, a regression introduced in #1333
The issue is
faprefix has been deprecated in Font Awesome 5. The new default isfas.Checklist
Affected core subsystem(s)
UI
Refers/Fixes
Fixes #1353